issue after upgrading: PHP Fatal error: Uncaught TypeError: PHPStan\Reflection\BetterReflection ....

[usefksa]

Hello,
Thanks for the great tool.
After upgrading from 0.12.1 to 0.12.75 , I got this error when I run vendor/bin/phpstan analyse -l 6 MyProject

# vendor/bin/phpstan  analyse -l 6 MyProject 
Note: Using configuration file /var/www/phpstan.neon.
[12-Feb-2021 22:32:11 Asia/Riyadh] PHP Fatal error:  Uncaught TypeError: PHPStan\Reflection\BetterReflection\SourceLocator\ComposerJsonAndInstalledJsonSourceLocatorMaker::PHPStan\Reflection\BetterReflection\SourceLocator\{closure}(): Argument #1 ($path) must be of type string, array given in phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/BetterReflection/SourceLocator/ComposerJsonAndInstalledJsonSourceLocatorMaker.php:164
Stack trace:
#0 [internal function]: PHPStan\Reflection\BetterReflection\SourceLocator\ComposerJsonAndInstalledJsonSourceLocatorMaker::PHPStan\Reflection\BetterReflection\SourceLocator\{closure}(Array)
#1 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/BetterReflection/SourceLocator/ComposerJsonAndInstalledJsonSourceLocatorMaker.php(166): array_map(Object(Closure), Array)
#2 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/BetterReflection/SourceLocator/ComposerJsonAndInstalledJsonSourceLocatorMaker.php(50): PHPStan\Reflection\BetterReflection\SourceLocator\ComposerJsonAndInstalledJsonSourceLocatorMaker->prefixPaths(Array, '/var/www/')
#3 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/BetterReflection/BetterReflectionSourceLocatorFactory.php(131): PHPStan\Reflection\BetterReflection\SourceLocator\ComposerJsonAndInstalledJsonSourceLocatorMaker->create('/var/www')
#4 /tmp/phpstan/cache/nette.configurator/Container_daef59e8b8.php(5008): PHPStan\Reflection\BetterReflection\BetterReflectionSourceLocatorFactory->create()
#5 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Container.php(157): Container_daef59e8b8->createServiceBetterReflectionSourceLocator()
#6 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Container.php(90): _HumbugBox988107da0601\Nette\DI\Container->createService('betterReflectio...')
#7 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/DependencyInjection/ContainerFactory.php(68): _HumbugBox988107da0601\Nette\DI\Container->getService('betterReflectio...')
#8 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/Command/CommandHelper.php(193): PHPStan\DependencyInjection\ContainerFactory->create('/tmp/phpstan', Array, Array, Array, Array, '6', NULL, NULL, NULL)
#9 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/Command/AnalyseCommand.php(81): PHPStan\Command\CommandHelper::begin(Object(_HumbugBox988107da0601\Symfony\Component\Console\Input\ArgvInput), Object(_HumbugBox988107da0601\Symfony\Component\Console\Output\ConsoleOutput), Array, NULL, NULL, NULL, Array, '/var/www/phpsta...', NULL, '6', false, true, false)
#10 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Command/Command.php(228): PHPStan\Command\AnalyseCommand->execute(Object(_HumbugBox988107da0601\Symfony\Component\Console\Input\ArgvInput), Object(_HumbugBox988107da0601\Symfony\Component\Console\Output\ConsoleOutput))
#11 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(856): _HumbugBox988107da0601\Symfony\Component\Console\Command\Command->run(Object(_HumbugBox988107da0601\Symfony\Component\Console\Input\ArgvInput), Object(_HumbugBox988107da0601\Symfony\Component\Console\Output\ConsoleOutput))
#12 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(237): _HumbugBox988107da0601\Symfony\Component\Console\Application->doRunCommand(Object(PHPStan\Command\AnalyseCommand), Object(_HumbugBox988107da0601\Symfony\Component\Console\Input\ArgvInput), Object(_HumbugBox988107da0601\Symfony\Component\Console\Output\ConsoleOutput))
#13 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(138): _HumbugBox988107da0601\Symfony\Component\Console\Application->doRun(Object(_HumbugBox988107da0601\Symfony\Component\Console\Input\ArgvInput), Object(_HumbugBox988107da0601\Symfony\Component\Console\Output\ConsoleOutput))
#14 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/bin/phpstan(76): _HumbugBox988107da0601\Symfony\Component\Console\Application->run()
#15 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/bin/phpstan(77): _HumbugBox988107da0601\{closure}()
#16 /var/www/vendor/phpstan/phpstan/phpstan(8): require('phar:///var/www...')
#17 {main}
  thrown in phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/BetterReflection/SourceLocator/ComposerJsonAndInstalledJsonSourceLocatorMaker.php on line 164
Fatal error: Uncaught TypeError: PHPStan\Reflection\BetterReflection\SourceLocator\ComposerJsonAndInstalledJsonSourceLocatorMaker::PHPStan\Reflection\BetterReflection\SourceLocator\{closure}(): Argument #1 ($path) must be of type string, array given in phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/BetterReflection/SourceLocator/ComposerJsonAndInstalledJsonSourceLocatorMaker.php:164
Stack trace:
#0 [internal function]: PHPStan\Reflection\BetterReflection\SourceLocator\ComposerJsonAndInstalledJsonSourceLocatorMaker::PHPStan\Reflection\BetterReflection\SourceLocator\{closure}(Array)
#1 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/BetterReflection/SourceLocator/ComposerJsonAndInstalledJsonSourceLocatorMaker.php(166): array_map(Object(Closure), Array)
#2 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/BetterReflection/SourceLocator/ComposerJsonAndInstalledJsonSourceLocatorMaker.php(50): PHPStan\Reflection\BetterReflection\SourceLocator\ComposerJsonAndInstalledJsonSourceLocatorMaker->prefixPaths(Array, '/var/www/')
#3 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/BetterReflection/BetterReflectionSourceLocatorFactory.php(131): PHPStan\Reflection\BetterReflection\SourceLocator\ComposerJsonAndInstalledJsonSourceLocatorMaker->create('/var/www')
#4 /tmp/phpstan/cache/nette.configurator/Container_daef59e8b8.php(5008): PHPStan\Reflection\BetterReflection\BetterReflectionSourceLocatorFactory->create()
#5 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Container.php(157): Container_daef59e8b8->createServiceBetterReflectionSourceLocator()
#6 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Container.php(90): _HumbugBox988107da0601\Nette\DI\Container->createService('betterReflectio...')
#7 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/DependencyInjection/ContainerFactory.php(68): _HumbugBox988107da0601\Nette\DI\Container->getService('betterReflectio...')
#8 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/Command/CommandHelper.php(193): PHPStan\DependencyInjection\ContainerFactory->create('/tmp/phpstan', Array, Array, Array, Array, '6', NULL, NULL, NULL)
#9 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/Command/AnalyseCommand.php(81): PHPStan\Command\CommandHelper::begin(Object(_HumbugBox988107da0601\Symfony\Component\Console\Input\ArgvInput), Object(_HumbugBox988107da0601\Symfony\Component\Console\Output\ConsoleOutput), Array, NULL, NULL, NULL, Array, '/var/www/phpsta...', NULL, '6', false, true, false)
#10 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Command/Command.php(228): PHPStan\Command\AnalyseCommand->execute(Object(_HumbugBox988107da0601\Symfony\Component\Console\Input\ArgvInput), Object(_HumbugBox988107da0601\Symfony\Component\Console\Output\ConsoleOutput))
#11 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(856): _HumbugBox988107da0601\Symfony\Component\Console\Command\Command->run(Object(_HumbugBox988107da0601\Symfony\Component\Console\Input\ArgvInput), Object(_HumbugBox988107da0601\Symfony\Component\Console\Output\ConsoleOutput))
#12 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(237): _HumbugBox988107da0601\Symfony\Component\Console\Application->doRunCommand(Object(PHPStan\Command\AnalyseCommand), Object(_HumbugBox988107da0601\Symfony\Component\Console\Input\ArgvInput), Object(_HumbugBox988107da0601\Symfony\Component\Console\Output\ConsoleOutput))
#13 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(138): _HumbugBox988107da0601\Symfony\Component\Console\Application->doRun(Object(_HumbugBox988107da0601\Symfony\Component\Console\Input\ArgvInput), Object(_HumbugBox988107da0601\Symfony\Component\Console\Output\ConsoleOutput))
#14 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/bin/phpstan(76): _HumbugBox988107da0601\Symfony\Component\Console\Application->run()
#15 phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/bin/phpstan(77): _HumbugBox988107da0601\{closure}()
#16 /var/www/vendor/phpstan/phpstan/phpstan(8): require('phar:///var/www...')
#17 {main}
  thrown in phar:///var/www/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/BetterReflection/SourceLocator/ComposerJsonAndInstalledJsonSourceLocatorMaker.php on line 164
# 

the tool works fine if I downgrade to 0.12.1.
Any idea or hint to fix it or debug it?

[ondrejmirtes]

Hi, please post your composer.json and composer.lock and I'll try to reproduce it. Post it to gist.github.com, thanks.

[ondrejmirtes]

Anyway, my guess is that the reason is this: composer/composer#9229

[usefksa]

Thanks for the hint.
Yeah it is because of that. I refactor the code to get rid of classmap. It is fixed.