infer type via isset condition

[staabm]

Feature request

no error in https://phpstan.org/r/d4d3024d-f355-4d05-968d-d7cc6a2e1dcf

found while investigating phpstan/phpstan-src#2666 (comment)

[ondrejmirtes]

Alright, I looked into this in detail and this is what I found out. The fact that before it didn't report an error was a happy accident and actually a bug because revertNonNullability restored the expression with wrong certainty.

We need to make PHPStan understand what $link_mode = isset($shortcut_id) ? "remove" : "add"; does and create a conditional expression based on that. I'm try to gonna look into it.

[ondrejmirtes]

I managed to fix this on top of your PR with this commit: phpstan/phpstan-src@c1310c4

[staabm]

Thanks!

[staabm]

Should be re-opened because of revert

[ondrejmirtes]

Fixed: phpstan/phpstan-src#2710

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.