Type from multiple Closures is not unioned

[mvorisek]

Bug report

Currently, only the first Closure is analysed.

Code snippet that reproduces the problem

https://phpstan.org/r/06a4c6f9-99ec-4f9c-a8ca-d4a14633b153

once fixed, check https://phpstan.org/r/d77648c1-796f-41b3-abc0-a548b71ff927

Expected output

no phpstan error

[bendavies]

this works
https://phpstan.org/r/eda0d15a-982b-4fdf-ba3a-7e92a5812985

[mvorisek]

more complex repro: https://phpstan.org/r/910e8ba5-aca3-413f-8d61-fff88db292d8

[phpstan-bot]

@mvorisek After the latest push in 1.11.x, PHPStan now reports different result with your code snippet:

@@ @@
-PHP 7.4 – 8.3 (7 errors)
+PHP 7.4 – 8.3 (5 errors)
 ==========
 
 13: Strict comparison using !== between JsExpressionable and null will always evaluate to true.
@@ @@
 26: Strict comparison using !== between JsExpressionable|void and null will always evaluate to true.
 27: Method Cl::test2() should return JsExpressionable|null but returns JsExpressionable|void.
 30: Unreachable statement - code above always terminates.
-38: Parameter #1 $fx of method Cl::test() expects (Closure(): JsExpressionable)|(Closure(): void), Closure(): null given.
-39: Parameter #1 $fx of method Cl::test2() expects Closure(): (JsExpressionable|void), Closure(): null given.
 
 PHP 7.2 – 7.3 (6 errors)
 ==========

Full report

PHP 7.4 – 8.3 (5 errors)

Line	Error
13	Strict comparison using !== between JsExpressionable and null will always evaluate to true.
17	Unreachable statement - code above always terminates.
26	`Strict comparison using !== between JsExpressionable
27	`Method Cl::test2() should return JsExpressionable
30	Unreachable statement - code above always terminates.

PHP 7.2 – 7.3 (6 errors)

Line	Error
34	Syntax error, unexpected ')' on line 34
34	Syntax error, unexpected T_DOUBLE_ARROW, expecting ')' on line 34
35	Syntax error, unexpected ')' on line 35
35	Syntax error, unexpected T_DOUBLE_ARROW, expecting ')' on line 35
38	Syntax error, unexpected T_DOUBLE_ARROW, expecting ')' on line 38
39	Syntax error, unexpected T_DOUBLE_ARROW, expecting ')' on line 39

[ondrejmirtes]

Fixed: phpstan/phpstan-src#2902

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.