offsetAccess.nonOffsetAccessible suppressed by isset

[robchett]

Bug report

Error exception is raised but no warning from SA.

Code snippet that reproduces the problem

https://phpstan.org/r/4ade25a7-da2a-40ae-b3e3-89713d804052

Expected output

Cannot access offset 'a' on stdClass.

Did PHPStan help you today? Did it make you happy in any way?

No response

[ondrejmirtes]

/cc @rajyan You've touched this last in phpstan/phpstan-src#1174. Can you please look into this? Array access on stdClass even in isset() leads to fatal error: https://3v4l.org/GVD8v

[rajyan]

I think it's related to
#8393

but not sure enough why stdClass is not isOffsetAccessible->no.

[rajyan]

but not sure enough why stdClass is not isOffsetAccessible->no.

it's because stdClass is not final.
https://github.com/rajyan/phpstan-src/blob/c792050e6830a139ae746cff4b534573dfe8476a/src/Type/ObjectType.php#L1089-L1091

simply changing this line as

if ($classReflection->isFinal() || $classReflection->getName() === 'stdClass') {

can fix this issue, but haven't fully considered whether this is the right way.

[rajyan]

haven't fully considered whether this is the right way.

phpstan/phpstan-src@b55656f

we can create a class that implements ArrayAccess and extends stdClass at the same time.

https://3v4l.org/5nStL

so, we need to find a good compromise for the conditions for arrayOffsetAccessible that currently depends on ’final’.