Caching of method result results in false positives

[marcelthole]

Bug report

Hey,

it seems that the return type of a method is cached, even if the reference of the object has changed in a other service. Therefore a method can be called twice and the return type could be changed by a other service

Code snippet that reproduces the problem

This works fine:
https://phpstan.org/r/d7904a4a-44a6-4bb2-a889-cc1dde0732c7
This produce an error:
https://phpstan.org/r/63d35fc8-acbd-4809-b4fb-c1c3556b6f85

Expected output

I expect, that any change of a object results in a new check of the method return values

[ondrejmirtes]

To reword this bug report - when an object is passed somewhere, it should invalidate all it remembers about it in the current scope: (new PersistingService())->persist($sut);

[phpstan-bot]

@marcelthole PHPStan now reports different result with your code snippet:

@@ @@
+32: Call to function assert() with false will always evaluate to false.
 32: Strict comparison using !== between null and null will always evaluate to false.

Full report

Line	Error
32	Strict comparison using !== between null and null will always evaluate to false.
32	Strict comparison using !== between null and null will always evaluate to false.

[phpstan-bot]

@marcelthole After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-32: Strict comparison using !== between null and null will always evaluate to false.
+No errors

[ondrejmirtes]

Fixed: phpstan/phpstan-src@f92b95e

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.