Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignemt inside function call isn't passed correctly #3331

Closed
AJenbo opened this issue May 23, 2020 · 4 comments
Closed

Assignemt inside function call isn't passed correctly #3331

AJenbo opened this issue May 23, 2020 · 4 comments
Labels

Comments

@AJenbo
Copy link
Contributor

AJenbo commented May 23, 2020

Bug report

Assignment inside a function call is not passed correctly as the function won't be affecting the statically derived type of the variable.

if (is_object($obj = $this->getObj()))
// Incorrectly things that $obj can still be either an object or a null
$obj = $this->getObj();
if (is_object($obj))
// Correctly determin that $obj is an object.

Code snippet that reproduces the problem

https://phpstan.org/r/0e339d8a-da81-4edf-90f0-5f8150055d69

@phpstan-bot
Copy link
Contributor

@AJenbo After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-8: Cannot access property $something on stdClass|null.
+No errors

@ondrejmirtes
Copy link
Member

Fixed: phpstan/phpstan-src@b2bf703

@AJenbo
Copy link
Contributor Author

AJenbo commented May 9, 2021

Cool, also nice bot :)

ondrejmirtes added a commit to phpstan/phpstan-src that referenced this issue May 11, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants