PHP_MAJOR_VERSION always false comparison

[mvorisek]

Bug report

PHP_MAJOR_VERSION constant type is weirdly changed by using the constant in strict comparison.

Code snippet that reproduces the problem

https://phpstan.org/r/eb30f898-1007-4cea-9822-ad3cb3a49fa5

Expected output

no error

[ondrejmirtes]

PHP_MAJOR_VERSION is already one of the dynamicConstantNames (https://phpstan.org/config-reference#constants) so it shouldn't be possible to have this error.

[mvorisek]

Where it is defined? I am getting the error with the latest phpstan release.

[Kocal]

Here https://github.com/phpstan/phpstan-src/blob/master/conf/config.neon#L102

[ondrejmirtes]

Please reproduce that in a minimal repository.

[mvorisek]

I already tried to search for that, but I mean where the range is defined.

[ondrejmirtes]

What range? The constant is always an int: https://phpstan.org/r/23d36685-80b6-4e2c-be0e-0c7632c160b5

[mvorisek]

I was able to reproduce! Here it is: https://phpstan.org/r/eb30f898-1007-4cea-9822-ad3cb3a49fa5

[ondrejmirtes]

So weird.

[ghost]

I am trying to figure out if my problem is related to this bug. I've got the following code:

	$rc = hash_hmac($algo, $password, $hmac);
	if($rc === false)
		return false;

phpstan reports an error:

Strict comparison using === between string and false will always evaluate to false.

Sure, string and false will always evaluate to false, but the function hash_hmac may return a string or a false, thus my if statement will evaluate the === comparison to true.

 hash_hmac ( string $algo , string $data , string $key , bool $binary = false ) : string|false

Return Values

Returns a string containing the calculated message digest as lowercase hexits unless binary is set to true in which case the raw binary representation of the message digest is returned. Returns false when algo is unknown or is a non-cryptographic hash function.

ref: https://www.php.net/manual/en/function.hash-hmac

[ondrejmirtes]

@Bill-ColeUS It's not relevant to this issue at all. Open a new issue.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@42d0b36

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.