result of count() not taken into account

[pauljherring]

Bug report

.. or at least I think that may be what's wrong here...

If count($a) on an array assigned using multiple $a[] = ... returns more than zero items, then$a[0] should exist.

Code snippet that reproduces the problem

https://phpstan.org/r/bfc2aa88-7001-4b48-8b96-1ed4e72600e7

<?php declare(strict_types = 1);
/** 
 * Abbreviate an address - always show the first line, then work backwards from the most generic at the end
 * @param array{a?: string,
 * b?: string,
 * c?: string,
 * d?: string,
 * e?: string,
 * } $array array of things to show
 * @param int $count how many of them to show, the first one and $count-1
 * @return string;
 */
function abbrev($array, $count){
	if ($count < 1){
		return '';
	}
	$a = [];
	if (isset($array['a'])) $a[] = $array['a'];
	if (isset($array['b'])) $a[] = $array['b'];
	if (isset($array['c'])) $a[] = $array['c'];
	if (isset($array['d'])) $a[] = $array['d'];
	if (isset($array['e'])) $a[] = $array['e'];
	if (count($a) >= $count){ // count is > 0, so $a[0] must exist...
		$ret = implode(', ', array_merge([$a[0]], array_slice($a, -($count-1))));  // line 24
	}else{
		$ret = implode(', ', $a);
	}
	return $ret;
}

$address = [
	'a' => 'a',
	'b' => 'b',
	// c omitted
	'd' => 'd',
	'e' => 'e',
];

echo abbrev($address, 2)."\n";
echo abbrev($address, 5)."\n";
echo abbrev($address, 7)."\n";

$address = [
];
echo abbrev($address, 2)."\n";
echo abbrev($address, 5)."\n";
echo abbrev($address, 7)."\n";

Actual output

24 | Offset 0 does not exist on array()\|array(0 => string, ?1 => string, ?2 => string, ?3 => string, ?4 => string).

Expected output

No errors!

[ondrejmirtes]

This works: https://phpstan.org/r/846385ab-8a48-4fab-92b1-2fbc3d661c10

So it's just that TypeSpecifier does not support count($a) >= positive-int...

[pauljherring]

This works: https://phpstan.org/r/846385ab-8a48-4fab-92b1-2fbc3d661c10

But changes how the function works, sadly.

Ta, anyway.

[pauljherring]

But changes how the function works, sadly.

Found some cruft to add to fix that..

https://phpstan.org/r/d83efb70-2a4a-40c9-94c6-dcc34d8e7d3f

.. and I do appreciate your efforts on this btw - it's helped me a lot.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@7b417c7

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.