Unclear error message for missed constant enum

[fogush]

Bug report

An asterisk * for constant enumerations means all constants. When a function doesn't return all constants matched by the asterisk, PHPStan shows Method ... never returns string so it can be removed from the return typehint.. This looks really unclear. If the string word could be replaced with a specific list of constants that are not returned, it would be much better.

Code snippet that reproduces the problem

https://phpstan.org/r/31821eb7-2751-4a04-909f-dd8262fbfe0f

Expected output

Method Test::throwsPhpStanError() never returns StatusEnum::STATUS_OPEN so it can be removed from the return typehint.

[ondrejmirtes]

Yeah, this is just a question of using VerbosityLevel::getRecommendedLevelByType() here: https://github.com/phpstan/phpstan-src/blob/b11218bcf1a281fd6a1bbac69c0700a0d50f1564/src/Rules/TooWideTypehints/TooWideMethodReturnTypehintRule.php#L99

[phpstan-bot]

@fogush After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-22: Method Test::throwsPhpStanError() never returns string so it can be removed from the return typehint.
+22: Method Test::throwsPhpStanError() never returns 'open' so it can be removed from the return typehint.

Full report

Line	Error
22	Method Test::throwsPhpStanError() never returns 'open' so it can be removed from the return typehint.

[ondrejmirtes]

Fixed by: phpstan/phpstan-src@838d1e4

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.