False positive "Call to function is_array() with mixed will always evaluate to true."

[tugmaks]

Bug report

After bumping phpstan/phpstan from 0.12.86 to 0.12.87

Code snippet that reproduces the problem

https://phpstan.org/r/f44414ae-c1bd-436f-898d-6270c5a39268

Expected output

no errors

[limingxinleo]

#4995

[ondrejmirtes]

Fixed: phpstan/phpstan-src@187921e

[b-viguier]

Hi @ondrejmirtes 👋 😃
Thanks for this quick fix! Unfortunately, I still encounter the same message in 0.12.88 on a slightly different example:
https://phpstan.org/r/cea39a2f-9e36-4f01-87b6-2a135901ccac

Do you think it may be related? If not, I can open a distinct issue for more clarity.

[phpstan-bot]

@tugmaks After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-13: Call to function is_array() with mixed will always evaluate to true.
+No errors

[phpstan-bot]

@tugmaks After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-13: Call to function is_array() with mixed will always evaluate to true.
+-1: Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40
+Run PHPStan with --debug option and post the stack trace to:
+https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

Full report

Line

Error

-1

Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40Run PHPStan with --debug option and post the stack trace to:https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

[phpstan-bot]

@tugmaks After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-13: Call to function is_array() with mixed will always evaluate to true.
+19: Method HelloWorld::parsePhone() should return string|null but return statement is missing.
+19: Static method HelloWorld::parsePhone() is unused.

Full report

Line	Error
19	`Method HelloWorld::parsePhone() should return string
19	Static method HelloWorld::parsePhone() is unused.

[staabm]

@ondrejmirtes this one seems fixed and regression test is already committed in https://github.com/phpstan/phpstan-src/blob/1.9.x/tests/PHPStan/Rules/Comparison/data/bug-4999.php

[ondrejmirtes]

Thanks!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.