Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive when order of statements is changed #5162

Closed
mind-bending-forks opened this issue Jun 11, 2021 · 2 comments
Closed

False positive when order of statements is changed #5162

mind-bending-forks opened this issue Jun 11, 2021 · 2 comments

Comments

@mind-bending-forks
Copy link

Bug report

In certain circumstances, logic used to narrow down types is not correctly understood by phpstan.

Code snippet that reproduces the problem

https://phpstan.org/r/68974319-0f1f-4b77-9561-86f5da7cbc54

Expected output

  • phpstan should understand that $result2['a'] is numeric and so can be cast to float.
  • no errors reported by phpstan

Did PHPStan help you today? Did it make you happy in any way?

Yes

@phpstan-bot
Copy link
Contributor

@mind-bending-forks After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-42: Cannot cast array<string>|string to float.
+No errors

@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants