Regression when checking empty($array['key']) when 'key' is not optional

[ArtemGoutsoul]

There's a regression in 0.12.91

If the key is optional, the !empty() check works as expected.

If the key is not optional, then !empty() check turns the type of the checked array into *NEVER*:

12 | Parameter #1 $params of static method HelloWorld::method2() expects array('other_key' => string), *NEVER* given.

https://phpstan.org/r/80cbdf06-2aa6-4d72-b5e6-0f816a9b5ed8

Possibly related to the fix for #3297, but not sure how :(

[ArtemGoutsoul]

Tried to reproduce using tests:

• created a test php file /data/bug-5258.php from https://phpstan.org/r/80cbdf06-2aa6-4d72-b5e6-0f816a9b5ed8
• added a test to \PHPStan\Rules\Arrays\NonexistentOffsetInArrayDimFetchRuleTest::testBug5258

	public function testBug5258(): void
	{
		$this->analyse([__DIR__ . '/data/bug-5258.php'], []);
	}

• ran vendor/bin/paratest tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php
• but I'm not getting

12 | Parameter #1 $params of static method HelloWorld::method2() expects array('other_key' => string), *NEVER* given.

[ondrejmirtes]

Fixed, thanks! phpstan/phpstan-src@790a838

[ArtemGoutsoul]

Thank you!! 🥳

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.