Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-empty-string from implode() #5291

Closed
staabm opened this issue Jul 12, 2021 · 2 comments
Closed

Non-empty-string from implode() #5291

staabm opened this issue Jul 12, 2021 · 2 comments

Comments

@staabm
Copy link
Contributor

staabm commented Jul 12, 2021

Feature request

https://phpstan.org/r/26116517-f0e3-427e-990b-3d53c776449a

implode() on a non empty array with non empty glue-string, should return a non-empty-string

see also https://github.com/vimeo/psalm/blob/e93b37a2253f63b981c13694c8fb9c2e6a5bc7f4/stubs/CoreGenericFunctions.phpstub#L577

Did PHPStan help you today? Did it make you happy in any way?

@ondrejmirtes
Copy link
Member

Fixed: phpstan/phpstan-src@520ae22

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants