numeric-string not preserved when passed into generic constructor

[enumag]

Bug report

I hope I didn't make another mistake somewhere but this seems like a real bug to me. 🤔

Code snippet that reproduces the problem

https://phpstan.org/r/6382fe16-7dad-44ae-ac6f-9fdac6f531cf

Expected output

no error

[phpstan-bot]

@enumag After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-9: Function createIterator() should return ArrayIterator<int|string, string&numeric> but returns ArrayIterator<(int|string), string>.
+7: Function createIterator() should return ArrayIterator<int|string, string> but return statement is missing.

Full report

Line	Error
7	`Function createIterator() should return ArrayIterator<int

[phpstan-bot]

@enumag After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-9: Function createIterator() should return ArrayIterator<int|string, string&numeric> but returns ArrayIterator<(int|string), string>.
+9: Function createIterator() should return ArrayIterator<int|string, numeric-string> but returns ArrayIterator<(int|string), string>.

Full report

Line	Error
9	`Function createIterator() should return ArrayIterator<int

[Screenfeed]

Hi,
Sorry to zombify this ticket.

I have the same issue with array keys. See https://phpstan.org/r/fa4bb809-0552-4dcf-ae81-267c1bb35386.

[ondrejmirtes]

Last night I came up with the idea that we mostly shouldn't generalize the generic type variables, except when they're in object generics, like Foo<int>.

Here's the resulting PR: phpstan/phpstan-src#2818

We can't do this for objects, because I want new Collection([1, 2, 3]) to become Collection<int>. This could be improved in the future thanks to this suggestion: #6732 (comment) (but it's pretty complex to implement so for now it has to wait).

The new behaviour now only applies to bleeding edge (https://phpstan.org/blog/what-is-bleeding-edge) so definitely enable it to get the taste of the future 👍

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.