False positive: if ($city ?? false)

[lyrixx]

Hello.

There is a false positive here:

if ($city ?? false) { ... }

=> var $citiy is undefined

Thanks.

[ondrejmirtes]

Hi,
cannot reproduce this. Can you reproduce it on phpstan.org? Which version are you using?

[lookyman]

@ondrejmirtes https://phpstan.org/r/072c410813591662b41d5a6b5e81e2d6

[ondrejmirtes]

Thanks, that makes sense but wasn't included in the OP. Should be easy to fix.

[lyrixx]

I re-run the example, and the output is a bit different
https://phpstan.org/r/237c0227-c613-4804-95e9-2286ae5a8556

[phpstan-bot]

@lyrixx PHPStan now reports different result with your code snippet:

@@ @@
-3: If condition is always false.
-4: Undefined variable: $city
+4: Variable $city might not be defined.

Full report

Line	Error
4	Variable $city might not be defined.

[phpstan-bot]

@lyrixx After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-3: If condition is always false.
-4: Undefined variable: $city
+No errors

[ondrejmirtes]

Fixed: phpstan/phpstan-src@c4cc668

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.