Using trait with method renaming / visibility change triggers bogus errors for other uses of trait

[sad-spirit]

Bug report

If a trait is used converting a method to private in one class

    use SpecificFoo {
        doFoo as private doFooImpl;
    }

bogus errrors appear in other classes where the same trait is used

Private method FooBar::doFoo() overriding public method Foo::doFoo() should also be public.

while that method is actually public there.

Code snippet that reproduces the problem

https://phpstan.org/r/78866c94-e900-4e2f-be7d-3f724f817b8d

Expected output

No errors. The problem appeared first in phpstan 1.3

[dktapps]

This is the exact same issue I encountered with pmmp/PocketMine-MP#4684.

Simpler example: https://phpstan.org/r/5402d664-98c7-44ac-80ef-564dfab3a12f
https://3v4l.org/418La#v8.1.1

[dktapps]

I should also mention that this appears to corrupt the visibility for future analysed classes using the same trait, for example:
https://phpstan.org/r/2048596a-12db-4c0b-9c5f-d9dd78c1298b

The Sand1 class doesn't experience the bug, but Sand2 does.

[mvorisek]

Probably related with #6253 , also present since phpstan v1.3.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@fc5be6a

Root cause: Roave/BetterReflection#942

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.