Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab CI displays each step in progress bar after upgrading to 1.3.0 #6295

Closed
mhujer opened this issue Jan 3, 2022 · 7 comments
Closed

Comments

@mhujer
Copy link
Contributor

mhujer commented Jan 3, 2022

Bug report

After upgrading from 1.2.0 to 1.3.0, our Gitlab CI build shows each step in progress bar:

image

Before the upgrade it was displayed correctly so probably something changed in PHPStan, but I could not find any related change:

image

@mergeable
Copy link

mergeable bot commented Jan 3, 2022

This bug report is missing a link to reproduction on phpstan.org.

It will most likely be closed after manual review.

@mhujer mhujer changed the title Gitlab CI displays each step progress bar after upgrading to 1.3.0 Gitlab CI displays each step in progress bar after upgrading to 1.3.0 Jan 3, 2022
@ondrejmirtes
Copy link
Member

I think the reason must be the upgrade to Symfony 5.4, something must have changed there. Since we know we're running in CI, we could do something about it when rendering the progress bar.

@Carpenter0100
Copy link

I have the same issue on my local development environment since phpstan 1.3.0.
I am using symfony console 5.4.2.

@ondrejmirtes
Copy link
Member

I've tried something: phpstan/phpstan-src@0993d18

I'm not sure if it's going to fix your progress bar in CI to look much different, but at least it's going to be less text printed overall I think.

Feel free to test it :) Thanks.

@mhujer
Copy link
Contributor Author

mhujer commented Jan 6, 2022

Good enough, can be easily scrolled over. Thank you!

image

@ondrejmirtes
Copy link
Member

I still would love to be able to dive into the actual reason why this changed. On other systems there's a newline between each step.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants