compare of a float against 0 should error

[staabm]

Bug report

see https://3v4l.org/Nlt7t
related issue thecodingmachine/safe#286

Code snippet that reproduces the problem

https://phpstan.org/r/b2a1e65b-14ad-43de-82c3-4219635bce90

Expected output

error, because comparison of a float against int-0 always leads to true/false
atm we see only a single error

[ondrejmirtes]

"always true" is only reported with strict-rules (https://phpstan.org/r/be2789f5-5ea2-40bf-97cc-0fe9ba25dee8) or this option enabled: https://phpstan.org/config-reference#checkalwaystruestrictcomparison (check other similar options around that one in the documentation)

[herndlm]

Not entirely sure what the best phpstan behaviour would be here. I think it's still weird. Maybe report nothing?

But an identical/equal comparison of floats with anything is always problematic, right? Does it make sense to report this in a rule? I guess the only correct thing to do is smth like abs($foo) <= PHP_FLOAT_EPSILON or so for the 0 comparison .
I think, what I'm suggesting is, to make all == and === and their inversions/false contexts with floats error. Does that make sense?

[ondrejmirtes]

to make all == and === and their inversions/false contexts with floats error. Does that make sense?

There's an old PR about this with some discussion: phpstan/phpstan-strict-rules#38

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.