Generic Attributes does not guess the type of a class-string

[BrandonlinU]

Bug report

I update the Doctrine Library to the newest version (2.12.2 at the moment of writing) that incorporates psalm generics for the Entity attribute, but this cause that PHPStan report many errors relative with the parameter "repositoryClass", saying that my repositories (that extends the ServiceEntityRepository) was not allowed because it not represents a class-string for EntityRepository. Because ServiceEntityRepository extends from EntityRepository, it should be covariant.
It seems that the error is unique for the generic attributes, because I testes with generic classes and PHPStan is happy with the same type constraints.

Code snippet that reproduces the problem

https://phpstan.org/r/15c3b24f-ad7c-47b0-a1d2-da219cdd5edb

Expected output

It should not throw error

Did PHPStan help you today? Did it make you happy in any way?

I am not good with the words, but PHPStan help me catch many errors and save me tens of hours of painfull debugging. Keep going with that fantastic work!

[rs-ubaldi]

Same problem here today

[adrienlucas]

Seems like the same issue was encountered using psalm : doctrine/orm#9681

A fix of the doctrine/orm package is to be released (see doctrine/orm#9708) but as far as I tested, it does not solve phpstan usage.

[damosse31]

my temporary workaround in phpstan.neon to ignore this error

parameters:
	level: 8
	ignoreErrors:
		- '#repositoryClass(.*)expects class-string(.*)EntityRepository#'

[ondrejmirtes]

Fixed: phpstan/phpstan-src@361e064

[ondrejmirtes]

Fix released in PHPStan 1.6.8: https://github.com/phpstan/phpstan/releases/tag/1.6.8

[bytehead]

Thank you 🙏

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.