Report PossiblyDivisionByZero

[VincentLanglet]

Feature request

It could be useful to have phpstan report a possibly division by zero error.
Maybe it require to be an option or a strict rule.

https://phpstan.org/r/43bf5d53-27c4-4684-81f3-8dddcd805472

It might be easier for int since adding a 0 check is changing the value to int<min, -1>|int<1, max>.
For float, currently, a !== 0.0 check is not narrowing the type to something like non-negative-float or positive-float|negative-float.

[rajyan]

I think this feature seems implemented already
phpstan/phpstan-src#1280
you should enable some options to make phpstan report
https://phpstan.org/blog/bring-your-exceptions-under-control

as you mentioned, report for float is not possible yet.

[VincentLanglet]

I think this feature seems implemented already phpstan/phpstan-src#1280 you should enable some options to make phpstan report https://phpstan.org/blog/bring-your-exceptions-under-control

I often enable the exceptions checks of phpstan, but always disable it for \LogicException and \Error since it's an error from the code which shouldn't be try/catch.

To me DivisionByError is in the same situation and should have his own error reported by phpstan.

In the same way, TypeError is an error but phpstan reports when you're passing a possibly wrong type to a method.
Level 7 of phpstan reports passing string|int to a method which only accepts string.

[ondrejmirtes]

This is trivial to implement for integers: Report it if !(new ConstantIntegerType(0))->isSuperTypeOf($rightType)->no().

For floats it's not possible right now as we don't have FloatRangeType.

[VincentLanglet]

Started in phpstan/phpstan-src#1636

[VincentLanglet]

Closed because of phpstan/phpstan-src#1636 (comment)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.