LanguageLevelTypeAware From phpstorm-stubs

[staabm]

Feature request

Could/should we take #LanguageLevelTypeAware from phpstorm stubs into account?

see e.g. https://github.com/DmitryTronin/phpstorm-stubs/blob/8bcaf58b0672ab9c3e835159c6944dc9181df94a/SPL/SPL_f.php#L150

function iterator_to_array(
  #[LanguageLevelTypeAware(['8.2' => 'Traversable|array'], default: 'Traversable')] $iterator,
  bool $preserve_keys = true
): array {}

[ondrejmirtes]

Please false-positive/false-negative this would solve on phpstan.org/try.

[staabm]

For the above issue it would be, no error on line 10/11 for php 8.2+

We can achieve this also with existing signature mechanics though

https://phpstan.org/r/1570736d-c072-45a2-bad5-51ed6f41454a

[ondrejmirtes]

It's already correct here https://github.com/phpstan/php-8-stubs/blob/main/stubs/ext/spl/iterator_to_array.php, it just needs a fix in https://github.com/phpstan/phpstan-src/blob/1.8.x/src/Reflection/SignatureMap/Php8SignatureMapProvider.php I guess.

[genhoi]

Are there any plans to fix this problem?

[herndlm]

If it's tagged as a bug then it is considered to be a bug and will be worked on at some point.

[ondrejmirtes]

This is open-source - anyone can contribute a bugfix.

Are there any plans to fix this problem?

Honestly - if you really want this fixed then it's your job to fix it :)

[genhoi]

Honestly - if you really want this fixed then it's your job to fix it :)

Good suggestion, I'll try to make a fix this week

[phpstan-bot]

@staabm After the latest push in 1.11.x, PHPStan now reports different result with your code snippet:

@@ @@
+PHP 8.2 (3 errors)
+==========
+
+ 8: Method HelloWorld::sayHello() has parameter $arr with no value type specified in iterable type array.
+ 8: Method HelloWorld::sayHello() has parameter $itOrArr with no value type specified in iterable type array.
+ 8: Method HelloWorld::sayHello() has parameter $itOrArr with no value type specified in iterable type array|Iterator.
+
+PHP 7.1 – 8.1 (5 errors)
+==========
+
  8: Method HelloWorld::sayHello() has parameter $arr with no value type specified in iterable type array.
  8: Method HelloWorld::sayHello() has parameter $itOrArr with no value type specified in iterable type array.
  8: Method HelloWorld::sayHello() has parameter $itOrArr with no value type specified in iterable type array|Iterator.
 10: Parameter #1 $iterator of function iterator_to_array expects Traversable, array given.
 11: Parameter #1 $iterator of function iterator_to_array expects Traversable, array|Iterator given.

Full report

PHP 8.2 (3 errors)

Line	Error
8	Method HelloWorld::sayHello() has parameter $arr with no value type specified in iterable type array.
8	Method HelloWorld::sayHello() has parameter $itOrArr with no value type specified in iterable type array.
8	`Method HelloWorld::sayHello() has parameter $itOrArr with no value type specified in iterable type array

PHP 7.1 – 8.1 (5 errors)

Line	Error
8	Method HelloWorld::sayHello() has parameter $arr with no value type specified in iterable type array.
8	Method HelloWorld::sayHello() has parameter $itOrArr with no value type specified in iterable type array.
8	`Method HelloWorld::sayHello() has parameter $itOrArr with no value type specified in iterable type array
10	Parameter #1 $iterator of function iterator_to_array expects Traversable, array given.
11	`Parameter #1 $iterator of function iterator_to_array expects Traversable, array

[ondrejmirtes]

Fixed phpstan/phpstan-src#2625

I don't see any other function this would solve a problem for.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.