Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@readonly property allows private mutation #7778

Closed
zonuexe opened this issue Aug 11, 2022 · 1 comment · Fixed by phpstan/phpstan-src#1610
Closed

@readonly property allows private mutation #7778

zonuexe opened this issue Aug 11, 2022 · 1 comment · Fixed by phpstan/phpstan-src#1610
Labels
feature-request

Comments

@zonuexe
Copy link
Contributor

zonuexe commented Aug 11, 2022 •
edited

Feature request

phpstan/phpstan-src#1295 added PHPDoc @readonly, but like Psalm it would be useful allow changes in the private scope.

I propose to add a function with the same specifications as @psalm-allow-private-mutation and @psalm-readonly-allow-private-mutation implemented in Psalm.

refs phpstan/phpstan-src#1295, #7774, phpstan/phpstan-src#1609

Did PHPStan help you today? Did it make you happy in any way?

I am exploring PHPStan again for the PHP Conference Okinawa this month.
@zonuexe zonuexe mentioned this issue Aug 11, 2022
Merged
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement @phpstan-allow-private-mutation
2 participants
@ondrejmirtes @zonuexe