Cannot unset offset 'Review' on array{User: mixed}.

[gemal]

https://phpstan.org/r/f6f1e028-bcfa-4914-8189-82afd1e99de4

this seems like a bug in the latest version 1.8.6

[ondrejmirtes]

The type gets broken after the unset on line 37: https://phpstan.org/r/f3a3a3dd-3e92-4fb7-bddf-70e088850ed0

[mk-wieland]

this seems like a bug in the latest version 1.8.6

The bug is only in 1.8.7 and above though, right? For me, it's working in 1.8.6.

[ahmedash95]

@ondrejmirtes could it be related to phpstan/phpstan-src#1791?

[ondrejmirtes]

I don't think so, but you can always verify that by reproducing the bug and reverting your fix 😎

[gemal]

this seems like a bug in the latest version 1.8.6

The bug is only in 1.8.7 though, right? For me, it's working in 1.8.6.

I tested only in 1.8.7. But also present in 1.8.8

[paulijar]

Here is another similar but even simpler case: https://phpstan.org/r/0f640c5d-beb7-4c90-8b8b-142dd8ffebbc
Dectected on v1.9.1. Do you think this is the same bug or should it be reported separately?

[rvanvelzen]

@paulijar your case is not exactly the same because offset c definitely doesn't exist and it's handled poorly: https://phpstan.org/r/99b671b2-06b7-429d-b1b5-12525bb045c1

[paulijar]

your case is not exactly the same because offset c definitely doesn't exist

True. However, in my real-life case the array was actually parsed from a file so PhpStan had no chance to know its full contents, and I still got the same error message. And the code should be totally correct regardless of if c exists or not. But it's possible that my example doesn't accurately reflect the same problem as I saw on my real source code.

[paulijar]

Indeed the issue with my real-life code got fixed by Phpstan 1.9.2. 👍

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.