Skip to content

Asymmetric @property types #9062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jtojnar opened this issue Mar 20, 2023 · 4 comments · Fixed by phpstan/phpstan-src#2327
Closed

Asymmetric @property types #9062

jtojnar opened this issue Mar 20, 2023 · 4 comments · Fixed by phpstan/phpstan-src#2327
Labels
feature-request

Comments

@jtojnar
Copy link
Contributor

jtojnar commented Mar 20, 2023

Feature request

It would be useful to support having @property-read and @property-write with the same name but different types.

(Opening a feature request as asked in #7192.)

https://phpstan.org/r/185309f7-1998-475b-a250-ad8b0b0029eb
@jtojnar jtojnar mentioned this issue Mar 20, 2023
Merged
@ondrejmirtes
Copy link
Member

This piece of code would need some modification: https://github.com/phpstan/phpstan-src/blob/44e0d9a87798c940a9abeaa2b6fe6d0b04611f16/src/PhpDoc/PhpDocNodeResolver.php#L92-L139

@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 20, 2023 •
edited
Loading

Thanks for the info. I can try to work on this.

@jtojnar jtojnar mentioned this issue Mar 20, 2023
Closed
@ondrejmirtes ondrejmirtes mentioned this issue Apr 5, 2023
Merged
@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 5, 2023

Thanks Ondřej. With phpstan/phpstan-src#2329, it now works as expected.

@github-actions
Copy link

github-actions bot commented May 7, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
2 participants
@ondrejmirtes @jtojnar