Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal error when calling in_array with one parameter #9711

Closed
devnix opened this issue Aug 1, 2023 · 3 comments
Closed

Internal error when calling in_array with one parameter #9711

devnix opened this issue Aug 1, 2023 · 3 comments

Comments

@devnix
Copy link

devnix commented Aug 1, 2023

Bug report

This would be the complete stacktrace:

Uncaught TypeError: PHPStan\Analyser\MutatingScope::getType(): Argument #1 ($node) must be of type PhpParser\Node\Expr, null given, called in phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Type/Php/InArrayFunctionTypeSpecifyingExtension.php on line 44 in phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php:536
#0 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Type/Php/InArrayFunctionTypeSpecifyingExtension.php(44): PHPStan\Analyser\MutatingScope->getType()
#1 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/TypeSpecifier.php(316): PHPStan\Type\Php\InArrayFunctionTypeSpecifyingExtension->specifyTypes()
#2 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Rules/Comparison/ImpossibleCheckTypeHelper.php(204): PHPStan\Analyser\TypeSpecifier->specifyTypesInCondition()
#3 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Type/Php/TypeSpecifyingFunctionsDynamicReturnTypeExtension.php(68): PHPStan\Rules\Comparison\ImpossibleCheckTypeHelper->findSpecifiedType()
#4 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(1509): PHPStan\Type\Php\TypeSpecifyingFunctionsDynamicReturnTypeExtension->getTypeFromFunctionCall()
#5 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(562): PHPStan\Analyser\MutatingScope->resolveType()
#6 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Rules/Functions/CallToFunctionStatementWithoutSideEffectsRule.php(97): PHPStan\Analyser\MutatingScope->getType()
#7 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/FileAnalyser.php(104): PHPStan\Rules\Functions\CallToFunctionStatementWithoutSideEffectsRule->processNode()
#8 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(441): PHPStan\Analyser\FileAnalyser->PHPStan\Analyser\{closure}()
#9 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(353): PHPStan\Analyser\NodeScopeResolver->processStmtNode()
#10 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/FileAnalyser.php(173): PHPStan\Analyser\NodeScopeResolver->processNodes()
#11 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/Analyser.php(72): PHPStan\Analyser\FileAnalyser->analyseFile()
#12 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Command/AnalyserRunner.php(62): PHPStan\Analyser\Analyser->analyse()
#13 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Command/AnalyseApplication.php(207): PHPStan\Command\AnalyserRunner->runAnalyser()
#14 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Command/AnalyseApplication.php(100): PHPStan\Command\AnalyseApplication->runAnalyser()
#15 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/src/Command/AnalyseCommand.php(195): PHPStan\Command\AnalyseApplication->analyse()
#16 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Command/Command.php(259): PHPStan\Command\AnalyseCommand->execute()
#17 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(870): _PHPStan_d55c4f2c2\Symfony\Component\Console\Command\Command->run()
#18 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(261): _PHPStan_d55c4f2c2\Symfony\Component\Console\Application->doRunCommand()
#19 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(157): _PHPStan_d55c4f2c2\Symfony\Component\Console\Application->doRun()
#20 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/bin/phpstan(124): _PHPStan_d55c4f2c2\Symfony\Component\Console\Application->run()
#21 phar:///home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan.phar/bin/phpstan(125): _PHPStan_d55c4f2c2\{closure}()
#22 /home/devnix/**REDACTED**/vendor/phpstan/phpstan/phpstan(8): require('...')
#23 /home/devnix/**REDACTED**/vendor/bin/phpstan(120): include('...')

Code snippet that reproduces the problem

https://phpstan.org/r/42b822d6-b77b-415a-88c2-9fe900e5d0cc

Expected output

I guess that an expected output would be

Function in_array invoked with X parameters, 2-3 required.

Did PHPStan help you today? Did it make you happy in any way?

Hell yeah, you know it!

@lulco
Copy link

lulco commented Aug 5, 2023

Looks like it was introduced here phpstan/phpstan-src@373e14e

It should be checked if func call has at least 2 (or 3?) args

@ondrejmirtes
Copy link
Member

Fixed: phpstan/phpstan-src@4d77e98

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants