Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart Sass 2.0.0 #678

Open
Valexr opened this issue May 23, 2021 · 7 comments
Open

Dart Sass 2.0.0 #678

Valexr opened this issue May 23, 2021 · 7 comments

Comments

@Valexr
Copy link

Valexr commented May 23, 2021

Screenshot 2021-05-23 at 07 11 20

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation:

math.div($control-size-sm - $line-height, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

@navanshu
Copy link

Updates are requiered in icons-action as well.

@Valexr
Copy link
Author

Valexr commented May 25, 2021

Yep👌🏻I post code just for example… many places needs update 😁in this good css-framework 🤓
& dark theme will be nice👍🏻 now mix colours logic doesn’t allow make it with simple change based colours…

@navanshu
Copy link

navanshu commented May 25, 2021

Hear me out, Sass is okay but writing math.div againts / is counter intutive to the whole sass thing that sass makes it easy. I didn't at all like this or sass. I never did more of a PostCSS person.

Though I would be glad to contribute for making dark and light theme, while keeping the size down but that might break the existing users of spectre.

@mlbiche
Copy link

mlbiche commented Jun 1, 2021

I opened a PR (#669) few weeks ago to update the project to Dart Sass (use of @use instead of @import). I have recently seen the math.div warning on another project, and I think this can be done within my PR. But it seems that the project is no longer maintained, especially with the list of PRs waiting...

@navanshu
Copy link

navanshu commented Jun 2, 2021

Why are they changing the syntax so much, not like they are adding any new feature.
I guess it is easier to just write css in js and transform it write from there and write it to a file. Then using any of the frameworks.

@Valexr
Copy link
Author

Valexr commented Jun 10, 2021

Simplest fix

npm install -g sass-migrator
sass-migrator division **/*.scss

@linonetwo
Copy link

If sir @picturepan2 is not going to update this, users can add

"postinstall": "sass-migrator division node_modules/spectre.css/src/*.scss"

and npm i -D sass-migrator, to fix this on userland.

linonetwo added a commit to tiddly-gittly/super-tag that referenced this issue Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants