Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control how to show the arrow when the target is not in the DOM #126

Open
harshmaur opened this issue Nov 23, 2020 · 2 comments
Open

Control how to show the arrow when the target is not in the DOM #126

harshmaur opened this issue Nov 23, 2020 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@harshmaur
Copy link

When we render the ArcherElements dynamically, there could be times, when the target element is not yet visible in the DOM.
In such cases the arrow doesnt display properly.
Screenshot 2020-11-23 at 6 59 30 PM

Is it possible to control the behaviour of the arrows (like hide them completely, or change the color/direction) when the target is not present?

@pierpo
Copy link
Owner

pierpo commented Nov 24, 2020

Hi!

It would make sense to at least hide the arrows indeed. This can be considered a bug!

Controlling the position is possible but harder to implement 😊 And that would be a new feature, I think.

No ETA on both, but the priority should be on the bug!

@pierpo pierpo added bug Something isn't working enhancement New feature or request labels Nov 24, 2020
@harshmaur
Copy link
Author

I will create a PR that hides the arrow.

harshmaur added a commit to harshmaur/react-archer that referenced this issue Nov 24, 2020
harshmaur added a commit to harshmaur/react-archer that referenced this issue Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants