Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArcherContainer content container fixed height '100%' don't work on dynamic content #192

Open
timtong1982 opened this issue May 1, 2023 · 2 comments

Comments

@timtong1982
Copy link

in my case we have a long paragraph who is hosting in a fix sized div and that div offers overflow scroll for it, since the code in

ArcherContainer

does:
<div style={{ height: '100%', }} ref={parent} > {newChildren} </div>

any svg path draw after the initial width will not being rendered

suggest have a customizable for this div

what is process of submitting a PR, I can raise one

@pierpo
Copy link
Owner

pierpo commented May 2, 2023

Hey! Can you share an example, a screenshot, even better a code sandbox?
My intuition is that it's not the lib's responsibility :) If you want a bigger canvas on which the arrows will work, you need to provide a bigger div. The lib can't extend the SVG container element size on its own.

@YoussefLaunchUp
Copy link

@timtong1982 I think I had the same issue. I was able to fix it by setting the display of the ArcherContainer to display: 'inline-block' and it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants