-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing for react-step-progress-bar #20
Comments
Same issue when i tried in one f my react project |
same issue here 🤔😕😕 |
I solve this issue declaring my own declare module 'react-step-progress-bar' {
interface ProgressBarProps {
percent?: number;
filledBackground?: any;
height?: string | number;
stepPositions?: number;
}
interface StepProps {
transition?: any;
position?: any;
}
class ProgressBar extends React.Component<ProgressBarProps, any> {}
class Step extends React.Component<StepProps, any> {}
} Thanks!!!! |
Thank you so much for your feedbacks ! I'll use typescript for the 2.0 ! |
Had a closer look to the package code and made a couple of changes to @ghernandezr's types:
|
I have same issue in typescript |
ProgressBarProps also needs children so...
|
Thank you @tomniermann @andresdsep 🙏 I hope the types will be included in future releases! |
@pierreericgarcia I'm looking forward to help with adding types and or transforming the code base into typescript but I don't see branches for that matter, I'd love to get in touch with you if there is more I should know about the migration to typescript 🙏 |
Thank you very much, for typing this awesome library🚀🚀🚀 |
First of all, thank you for this amazing library, now that i'm using it in a Typescript project, i was looking for its types i tried
npm install @types/react-step-progress-bar
but it does not exist.The text was updated successfully, but these errors were encountered: