Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading Json that contains comments #4

Open
Numpsy opened this issue Mar 24, 2023 · 2 comments
Open

Reading Json that contains comments #4

Numpsy opened this issue Mar 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Numpsy
Copy link

Numpsy commented Mar 24, 2023

Hi,

It looks to me like Jay doesn't like parsing Json that contains comments...
Those might not be 'officially' supported, but I see that FSharp.Data was changed to ignore them rather than breaking in fsprojects/FSharp.Data#1448, so would there be any interest in trying to port that change over to here?
@pimbrouwers pimbrouwers added the enhancement New feature or request label Mar 24, 2023
@pimbrouwers
Copy link
Owner

Hey Richard,

Thanks for reaching out.

This is definitely an upgrade we want to make. Are you comfortable spearheading that? Or would you like me to take care of it?

@Numpsy
Copy link
Author

Numpsy commented Mar 24, 2023

I'll give it a go

@Numpsy Numpsy mentioned this issue Mar 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Numpsy @pimbrouwers