Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pimcore 7] Discussion: just support for Symfony v5? #7283

Closed
brusch opened this issue Oct 12, 2020 · 15 comments · Fixed by #7559
Closed

[Pimcore 7] Discussion: just support for Symfony v5? #7283

brusch opened this issue Oct 12, 2020 · 15 comments · Fixed by #7559

Comments

@brusch
Copy link
Member

brusch commented Oct 12, 2020

... and dropping support for Symfony v4.

@brusch brusch added this to the 7.0.0 milestone Oct 12, 2020
@brusch brusch added the Task label Oct 12, 2020
@dpfaffenbauer
Copy link
Contributor

I'd be down :)

@albertmueller
Copy link
Contributor

i am also in favour

@aarongerig
Copy link
Contributor

Would be happy with that as well. 👍🏻

@Blackbam
Copy link
Contributor

Would be great.

@thgross
Copy link
Contributor

thgross commented Oct 12, 2020

There is no way to update all out existing pimcore installations by february 2021.

Since Symfony 5 does no longer support PHP-Templating, every layout, template and areablock needs to be rewritten.

Are there any plans to support pimcore 6.x even after the release of pimcore 7?

@brusch
Copy link
Member Author

brusch commented Oct 12, 2020

Pimcore 7 will anyway drop support for PHP templates, see #7224

Yes, 6.8.x will be further supported by our commercial offering (Enterprise Subscription). It is also planned to offer the PHP templating support for v7 as an enterprise bundle.

@Yivan
Copy link
Contributor

Yivan commented Oct 12, 2020

Hello, thanks for opening a discussion about this.

Just to give our way to work on projects with Pimcore, on our side, we don't use at all twig, all our project use the PHP template rendering.
Making the jump to Symfony 5 will be a big work for all our customer, and probably many of them wont upgrade so, except those using the enterprise bundle.

I would say, I would prefer drop Symfony 4 (it seems it is a less breaker than dropping php template) but keep PHP templating working in Pimcore 7 as native feature : )

Having the possibility to have the php template working as enterprise bundle is a good thing, thanks for making this possible. I think it is important so current users/customers can stay and be happy of their Pimcore choice.
I know Pimcore team made any major upgrade the more fluid possible, think about the compatibility of Zend in conjonction of Symfony, really a very good attention for your Pimcore users/developpers ! I appreciate this and wanted to say it here. I am confident with Pimcore 7 👍

@Blackbam
Copy link
Contributor

Blackbam commented Oct 13, 2020

Hello, thanks for opening a discussion about this.

Just to give our way to work on projects with Pimcore, on our side, we don't use at all twig, all our project use the PHP template rendering.
Making the jump to Symfony 5 will be a big work for all our customer, and probably many of them wont upgrade so, except those using the enterprise bundle.

I would say, I would prefer drop Symfony 4 (it seems it is a less breaker than dropping php template) but keep PHP templating working in Pimcore 7 as native feature : )

Having the possibility to have the php template working as enterprise bundle is a good thing, thanks for making this possible. I think it is important so current users/customers can stay and be happy of their Pimcore choice.
I know Pimcore team made any major upgrade the more fluid possible, think about the compatibility of Zend in conjonction of Symfony, really a very good attention for your Pimcore users/developpers ! I appreciate this and wanted to say it here. I am confident with Pimcore 7

My opinion about this is that dropping PHP templates is a good thing, because PHP templates do not give you any certain benefits over Twig templates. I know PHP itself is a templating language and if you are using it in a clean and structured way this is sufficient.

However I have seen a lot of horrible PHP templates in (Pimcore) legacy projects, containing logic and super confusing output generation.. It is a good thing that Twig forces you to seperate the views from the logic and you can do just anything with Twig as with PHP (even way more) if writing Twig extensions.

For legacy projects of course some refactoring might be required and you have to learn Twig, but IMHO its worth it.

@brusch
Copy link
Member Author

brusch commented Oct 13, 2020

Just for reference, Pimcore will drop the support for PHP templates anyway (see #7224), no matter if we continue to support Symfony 4 or not 😉

@markus-moser
Copy link
Contributor

Pimcore 7 Upgrades will be quite a bit of effort anyway therefore I'd say let's drop Symfony 4!

@dpfaffenbauer
Copy link
Contributor

@Yivan I told you many times to use Twig when Pimcore switched to Symfony, now it would have been a good idea to listen to me ;)

@ChrisB9
Copy link
Contributor

ChrisB9 commented Oct 13, 2020

Switching to symfony 5 would make this even much easier to support: #5387

@blankse
Copy link
Contributor

blankse commented Oct 13, 2020

I'm also for dropping Symfony v4 support. I think that would simplify a lot.

@grizzlydotweb
Copy link
Contributor

yeah drop it :)

@Yivan
Copy link
Contributor

Yivan commented Oct 13, 2020

@Yivan I told you many times to use Twig when Pimcore switched to Symfony, now it would have been a good idea to listen to me ;)

@dpfaffenbauer @Blackbam Yes I know, but we made choice to keep on with PHP Template. But like you say time is come for change : )

Let's drop symfony 4 in all case !

@brusch brusch mentioned this issue Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.