-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pimcore 7] Discussion: just support for Symfony v5? #7283
Comments
I'd be down :) |
i am also in favour |
Would be happy with that as well. 👍🏻 |
Would be great. |
There is no way to update all out existing pimcore installations by february 2021. Since Symfony 5 does no longer support PHP-Templating, every layout, template and areablock needs to be rewritten. Are there any plans to support pimcore 6.x even after the release of pimcore 7? |
Pimcore 7 will anyway drop support for PHP templates, see #7224 Yes, 6.8.x will be further supported by our commercial offering (Enterprise Subscription). It is also planned to offer the PHP templating support for v7 as an enterprise bundle. |
Hello, thanks for opening a discussion about this. Just to give our way to work on projects with Pimcore, on our side, we don't use at all twig, all our project use the PHP template rendering. I would say, I would prefer drop Symfony 4 (it seems it is a less breaker than dropping php template) but keep PHP templating working in Pimcore 7 as native feature : ) Having the possibility to have the php template working as enterprise bundle is a good thing, thanks for making this possible. I think it is important so current users/customers can stay and be happy of their Pimcore choice. |
My opinion about this is that dropping PHP templates is a good thing, because PHP templates do not give you any certain benefits over Twig templates. I know PHP itself is a templating language and if you are using it in a clean and structured way this is sufficient. However I have seen a lot of horrible PHP templates in (Pimcore) legacy projects, containing logic and super confusing output generation.. It is a good thing that Twig forces you to seperate the views from the logic and you can do just anything with Twig as with PHP (even way more) if writing Twig extensions. For legacy projects of course some refactoring might be required and you have to learn Twig, but IMHO its worth it. |
Just for reference, Pimcore will drop the support for PHP templates anyway (see #7224), no matter if we continue to support Symfony 4 or not 😉 |
Pimcore 7 Upgrades will be quite a bit of effort anyway therefore I'd say let's drop Symfony 4! |
@Yivan I told you many times to use Twig when Pimcore switched to Symfony, now it would have been a good idea to listen to me ;) |
Switching to symfony 5 would make this even much easier to support: #5387 |
I'm also for dropping Symfony v4 support. I think that would simplify a lot. |
yeah drop it :) |
@dpfaffenbauer @Blackbam Yes I know, but we made choice to keep on with PHP Template. But like you say time is come for change : ) Let's drop symfony 4 in all case ! |
... and dropping support for Symfony v4.
The text was updated successfully, but these errors were encountered: