Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move recital roles to p!stats card #78

Open
pianiststickman opened this issue Jun 30, 2019 · 10 comments
Open

Move recital roles to p!stats card #78

pianiststickman opened this issue Jun 30, 2019 · 10 comments

Comments

@pianiststickman
Copy link
Contributor

No description provided.

@Juliacare
Copy link
Collaborator

Ill make some card designs in the next few days in between piano practice. God smite me if I don't.

@Juliacare Juliacare added the Priority This above all else if possible label Jul 10, 2019
@Juliacare
Copy link
Collaborator

Achievement_card
recent_recital
one_to_five

ten_to_twentyfive
five_to_ten

@Juliacare
Copy link
Collaborator

twentyfive_to_fifty

@pianiststickman
Copy link
Contributor Author

Having thought about this for a bit, I'm convinced that the right thing to do is to convert the stats card to an embed. Several reasons:

  1. All of the information currently captured by the card, as well as its organization, fits neatly into an embed concept. Current session/overall time, ranks, and achievements turn into fields. The profile picture goes into the embed's thumbnail. The username becomes the title. Perhaps most crucially, badges can be implemented as custom emojis.
  2. We get Unicode support back by completely bypassing jimp.
  3. Animated thumbnails are actually animated in embeds.
  4. Embeds are flexible, graphics are not. If we run out of space on the graphic or want to add a new badge we have to upload new assets. We don't need to do any of that with an embed. (We would still potentially need to update logic to actually recognize when to award the badge, of course.)

@pianiststickman
Copy link
Contributor Author

pianiststickman commented Sep 26, 2019

So here's a first stab at badges and the graphics we'll need:

  • the :wtf: emoji to be used as a placeholder for having no badges
  • time badges: something like 🕐 or ⏱️ with the number 40 overlaid on top of it. Preferably put the number in the same yellow that we're currently using for the 40hr role on Discord. Maybe also add 100 and 200 as additional badges as well, which can be other colours. These to be uploaded as :FortyHours:, :HundredHours:, :TwoHundredHours: as custom emojis on the server.
  • leaderboard badges: some graphic to be awarded to anybody who has ever finished a session on the leaderboard, to be uploaded as :TopTen: as a custom emoji on the server. I would prefer not to have a badge for finishing first on the leaderboard.
  • recital badges: something like 🏆 or 🏅 with the number of the recital overlaid on top of it, in the colour of that recital's current role on Discord. These to be uploaded as :Recital_1:, :Recital_2:, etc. as custom emojis on the server.

I think that's a good start for now. Looking at the old list of achievements we floated around I do like the idea of "focused" as well, but we can worry about that later. Note that we'll need to upload the emojis first before the bot changes, because the bot requires the IDs of the emojis.

@Juliacare
Copy link
Collaborator

Juliacare commented Sep 27, 2019

recital badges: something like 🏆 or 🏅 with the number of the recital overlaid on top of it, in the colour of that recital's current role on Discord. These to be uploaded as :Recital_1:, :Recital_2:, etc. as custom emojis on the server.

I believe this is a bad idea and were better off simply listing out the recitals parcipated and then give a badge based on total recitals played like 1 5 10 15 20, bad idea because this is going to just increase work for the recital managers and theyre already so unmotivated to do half of the things we ask of them.

@Juliacare
Copy link
Collaborator

hundredhours
twofiftyhours
fivehundredhours
fortyhours

@pianiststickman
Copy link
Contributor Author

I still disagree regarding the recitals. First, it shouldn't be any more work for the RMs than what is currently happening. In fact it should make it easier, if the bot can batch process an entire role into a recital code (i.e. everybody with role "Performer" gets recital code 36 - that could be one command). The second reason is that early recital badges are a point of pride for our members with more lengthy tenures and I'd rather keep that by not reducing recital participation to "number of recitals played". It's possible that they don't need to be badges but a plain-text list seems like it'd be rather unaesthetic...

@Juliacare
Copy link
Collaborator

I'm just unsure how to make these recital badges work.
-We could have it generate a new badge based upon assets and just recolour the assets to a random hexcode from a list but that might give weird results or make all badges just recolours which can look a bit unappealing.
-Making a badge for every recital can be a bit tedious as the bot has to be updated every recital as well if that was the case.
-Another option is plain text which I have to agree looks kind of dull.
-Then theres the option of 1-5, 6-10, 11-15 etc which I understand can be a bit impersonal so to say.

@pianiststickman pianiststickman removed the Priority This above all else if possible label Jul 3, 2020
@pianiststickman
Copy link
Contributor Author

Quick triage comment: this is still a good idea, it's just probably more work than it's worth right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants