Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give names to colors. #28

Open
jinh0 opened this issue Apr 19, 2021 · 5 comments
Open

Give names to colors. #28

jinh0 opened this issue Apr 19, 2021 · 5 comments
Labels
help wanted Extra attention is needed meta Non-code related

Comments

@jinh0
Copy link
Collaborator

jinh0 commented Apr 19, 2021

Currently there are four colors that are named after Purple, and this hinders development.

Screen Shot 2021-04-19 at 3 20 49 PM

Suggestions are welcome for new names for the colors, for example, "Lavender" for the current "Purple" color.

@jinh0 jinh0 added enhancement New feature or request help wanted Extra attention is needed labels Apr 19, 2021
@spcbfr
Copy link

spcbfr commented May 4, 2021

Purple -> Lavender
Purple 2 -> Cyber Grape
Dark Purple -> Space Cadet
Dark Purple 2 -> Pearly Purple
@jinh0 what do you think ? 🟪

@jinh0
Copy link
Collaborator Author

jinh0 commented May 5, 2021

Hey @YoussefBouzekri , thanks for helping out! I agree we should change Purple to Lavender.

Cyber Grape instead of Purple2 sounds amazing; I'm thinking simply 'Grape' for short (also how is a grape cyber?).

I think Pearly Purple is too much of a tongue twister, though. Space Cadet means an astronaut, so I can't see a clear correlation with the color. What do you think about 'Void Purple' instead of Dark Purple? Dark Purple looks more black than purple.

I'll be sure to replace the color names for the first two in the code.

If you want to contribute more to spaceduck, check out the dev branch, we're currently refactoring basically everything.

@spcbfr
Copy link

spcbfr commented May 5, 2021

Thanks for the quick response @jinh0
I really like how Void Purple Sounds, but what about the rest of the colors (blue, green etc..), will you be renaming those out ?

@jinh0
Copy link
Collaborator Author

jinh0 commented May 5, 2021

I don't think they need renaming... yet ( @pineapplegiant is planning on making 16 colors in total). Each color has a unique name.

I made this issue because it was actually getting annoying to distinguish between four colors all named Purple in conversation. Thanks for solving the issue!

Now that I think about it... DarkPurple2 should be called Blueberry. Let me know what you think!

@spcbfr
Copy link

spcbfr commented May 5, 2021

I love it !

@jinh0 jinh0 added meta Non-code related help wanted Extra attention is needed and removed enhancement New feature or request help wanted Extra attention is needed labels May 26, 2021
@jinh0 jinh0 mentioned this issue May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed meta Non-code related
Projects
None yet
Development

No branches or pull requests

2 participants