Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs started to crash after 9.1.1 #463

Open
chrisands opened this issue Oct 2, 2023 · 2 comments
Open

nodejs started to crash after 9.1.1 #463

chrisands opened this issue Oct 2, 2023 · 2 comments

Comments

@chrisands
Copy link
Contributor

chrisands commented Oct 2, 2023

I used pino-pretty@8.0.0 after updating to latest version (10.2.0) I started to receive nodejs crashes after few logs

node[6333]: ../src/tcp_wrap.cc:155:static void node::TCPWrap::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[0]->IsInt32()' failed.
 1: 0x1089c4dc5 node::Abort() (.cold.1) [/Users/osiyuk/.local/share/fnm/node-versions/v18.14.2/installation/bin/node]
 2: 0x1074481e9 node::Abort() [/Users/osiyuk/.local/share/fnm/node-versions/v18.14.2/installation/bin/node]
 3: 0x107447fe1 node::Assert(node::AssertionInfo const&) [/Users/osiyuk/.local/share/fnm/node-versions/v18.14.2/installation/bin/node]
 4: 0x107522819 node::TCPWrap::New(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/osiyuk/.local/share/fnm/node-versions/v18.14.2/installation/bin/node]
 5: 0x107640c78 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [/Users/osiyuk/.local/share/fnm/node-versions/v18.14.2/installation/bin/node]
 6: 0x107640444 v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<true>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/Users/osiyuk/.local/share/fnm/node-versions/v18.14.2/installation/bin/node]
 7: 0x10763fe3b v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/Users/osiyuk/.local/share/fnm/node-versions/v18.14.2/installation/bin/node]
 8: 0x3a4c07d39

I tried different version and discovered that crashes started after pino-pretty@9.1.1. On @9.1.0 it still works okay.

I'll try add repo with reproduction. Maybe you have thoughts why this is happening?

@chrisands chrisands changed the title node start to crash after update to 9.1.1 nodejs started to crash after 9.1.1 Oct 2, 2023
@mcollina
Copy link
Member

mcollina commented Oct 2, 2023

No clue whatsoever, send out that repro!

@ondrejnebesky
Copy link

The same issue here. Interesting though that with two identical laptops and code the issue can only be reproduced only on one of them. Both running inside Docker and directly via npm. Reproduced on node 16, 18, and 20. Downgrading for now as older version seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants