Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check for numbers #70

Merged
merged 3 commits into from Jun 18, 2019
Merged

add check for numbers #70

merged 3 commits into from Jun 18, 2019

Conversation

ovhemert
Copy link
Contributor

Checks for number input and prevents crashing as reported in issue #69

Example: node -e 'console.log(2)' | node ./bin.js

davidmarkclements
davidmarkclements approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@davidmarkclements davidmarkclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

davidmarkclements
davidmarkclements requested changes Jun 18, 2019
View reviewed changes
Copy link
Member

@davidmarkclements davidmarkclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait, sorry could you please add a test for this

jsumners
jsumners approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

davidmarkclements
davidmarkclements approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@davidmarkclements davidmarkclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mcollina
mcollina approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 74a1894 into pinojs:master Jun 18, 2019
@ovhemert ovhemert deleted the number-input-check branch June 18, 2019 17:05
@Tiim Tiim mentioned this pull request Jun 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

@davidmarkclements davidmarkclements davidmarkclements approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ovhemert @mcollina @jsumners @davidmarkclements