Crash when logging date

[Tiim]

When i directly log JSON.stringified date with console.log without using pino then peno-pretty crashes with the following error message:

/code/node_modules/pino-pretty/lib/utils.js:178
   if ('level' in log === false) return undefined
               ^

 TypeError: Cannot use 'in' operator to search for 'level' in 2019-05-31T00:00:00.000Z
     at prettifyLevel (/code/node_modules/pino-pretty/lib/utils.js:178:15)
     at pretty (/code/node_modules/pino-pretty/index.js:85:29)
     at Transform.transform [as _transform] (/code/node_modules/pino-pretty/bin.js:38:18)
     at Transform._read (/code/node_modules/pino-pretty/node_modules/readable-stream/lib/_stream_transform.js:177:10)
     at Transform._write (/code/node_modules/pino-pretty/node_modules/readable-stream/lib/_stream_transform.js:164:83)
     at doWrite (/code/node_modules/pino-pretty/node_modules/readable-stream/lib/_stream_writable.js:405:139)
     at writeOrBuffer (/code/node_modules/pino-pretty/node_modules/readable-stream/lib/_stream_writable.js:394:5)
     at Transform.Writable.write (/code/node_modules/pino-pretty/node_modules/readable-stream/lib/_stream_writable.js:303:11)
     at Transform.ondata (/code/node_modules/split2/node_modules/readable-stream/lib/_stream_readable.js:662:20)
     at Transform.emit (events.js:196:13)

The following snipped in my code (fastify server) will produde this crash:

const value = JSON.stringify(new Date());
console.log(value);

I have not tested if this only works with stringified dates or if this is a bug when a string with start and end "quotes" gets logged.

I know this is already my second crash report, but apparently I'm a talent for finding crash bugs in pino-pretty 😅

[mcollina]

Would you mind sending a PR? Il giorno gio 27 giu 2019 alle 15:02 Tiim <notifications@github.com> ha scritto:

…

When i directly log JSON.stringified date with console.log without using pino then peno-pretty crashes with the following error message: /code/node_modules/pino-pretty/lib/utils.js:178 if ('level' in log === false) return undefined ^ TypeError: Cannot use 'in' operator to search for 'level' in 2019-05-31T00:00:00.000Z at prettifyLevel (/code/node_modules/pino-pretty/lib/utils.js:178:15) at pretty (/code/node_modules/pino-pretty/index.js:85:29) at Transform.transform [as _transform] (/code/node_modules/pino-pretty/bin.js:38:18) at Transform._read (/code/node_modules/pino-pretty/node_modules/readable-stream/lib/_stream_transform.js:177:10) at Transform._write (/code/node_modules/pino-pretty/node_modules/readable-stream/lib/_stream_transform.js:164:83) at doWrite (/code/node_modules/pino-pretty/node_modules/readable-stream/lib/_stream_writable.js:405:139) at writeOrBuffer (/code/node_modules/pino-pretty/node_modules/readable-stream/lib/_stream_writable.js:394:5) at Transform.Writable.write (/code/node_modules/pino-pretty/node_modules/readable-stream/lib/_stream_writable.js:303:11) at Transform.ondata (/code/node_modules/split2/node_modules/readable-stream/lib/_stream_readable.js:662:20) at Transform.emit (events.js:196:13) The following snipped in my code (fastify server) will produde this crash: const value = JSON.stringify(new Date()); console.log(value); I have not tested if this only works with stringified dates or if this is a bug when a string with start and end "quotes" gets logged. I know this is already my second crash report, but apparently I'm a talent for finding crash bugs in pino-pretty 😅 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#72?email_source=notifications&email_token=AAAMXY7GNMZAV4AUOEIPDOLP4S26VA5CNFSM4H33XWHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4CF3MA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAMXY5O7WDAB7IIC2YLS2DP4S26VANCNFSM4H33XWHA> .

[jsumners]

A plain string is valid JSON, thus it gets past the check:

pino-pretty/index.js

Lines 56 to 65 in a6b2032

	if (!isObject(inputData)) {
	const parsed = jsonParser(inputData)
	log = parsed.value
	if (parsed.err) {
	// pass through
	return inputData + EOL
	}
	} else {
	log = inputData
	}

Probably need another isObject check after JSON parsing to determine if we can go forward at:

pino-pretty/index.js

Lines 68 to 70 in a6b2032

	if ([null, true, false].includes(log) || Number.isFinite(log)) {
	return `${log}\n`
	}