Handle timestamp 0 in prettifyTime #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I was optimistic and did this on the fly. When I get to a saner environment I'll look at how badly I broke things! |
|
Would you mind adding unit tests for this?
Il giorno lun 12 ago 2019 alle 17:45 Zirak <notifications@github.com> ha
scritto:
… Sorry, I was optimistic and did this on the fly. When I get to a saner
environment I'll look at how badly I broke things!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#76?email_source=notifications&email_token=AAAMXY2CYUG6NYPPNMWNGLLQEGARRA5CNFSM4ILBTYT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4C6OAI#issuecomment-520480513>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAMXY4VFASLGISZ566243DQEGARRANCNFSM4ILBTYTQ>
.
|
When trying to format a log object like the following:
```json
{
"level": 30,
"time": 0,
"name": "foobar",
"msg": "I like cake",
"v": 1
}
```
pino-pretty previously tried to format the timestamp `undefined` instead of
taking the `0` time. This commit looks not at the truthiness of the value, but
its existence.
|
Tested and corrected my kerfuffle, sorry about the extra noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to format a log object like the following:
{ "level": 30, "time": 0, "name": "foobar", "msg": "I like cake", "v": 1 }pino-pretty previously tried to format the timestamp
undefinedinstead oftaking the
0time. This commit looks not at the truthiness of the value, butits existence.