Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through non-object valid JSON, fixes #72 #81

Merged
merged 1 commit into from Oct 8, 2019
Merged

Pass through non-object valid JSON, fixes #72 #81

merged 1 commit into from Oct 8, 2019

Conversation

timmarinin
Copy link
Contributor

  • Add test for passing through double-quoted string from JSON.stringify(new Date())
  • Check for parsed value being JS object, otherwise just fallthrough as on parse error

* Add test for passing through double-quoted string from JSON.stringify(new Date())
* Check for parsed value being JS object, otherwise just fallthrough as on parse error
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 71935ea into pinojs:master Oct 8, 2019
@timmarinin timmarinin deleted the feat/dont-crash-on-date branch October 8, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants