Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test pino.transport() with bundlers #1104

Closed
mcollina opened this issue Aug 28, 2021 · 5 comments · Fixed by #1209
Closed

test pino.transport() with bundlers #1104

mcollina opened this issue Aug 28, 2021 · 5 comments · Fixed by #1209
Labels
v7

Comments

@mcollina
Copy link
Member

A few of our users bundle their applications. While I recommend against doing it, we should verify pino.transport works properly for them too.
@mcollina mcollina added this to the v7.0.0 milestone Aug 28, 2021
@mcollina mcollina mentioned this issue Oct 15, 2021
Closed
@zekth
Copy link
Contributor

zekth commented Oct 15, 2021

Is a test stack like this fits the need? fastify/fastify#3240

@mcollina
Copy link
Member Author

yes! Specific for bundlers. Note that we would have to do something to make them work.

@zekth zekth mentioned this issue Oct 15, 2021
Closed
@mcollina mcollina mentioned this issue Nov 5, 2021
Merged
@mcollina mcollina removed this from the v7.0.0 milestone Nov 5, 2021
@mcollina mcollina added the v7 label Nov 5, 2021
@Unga
Copy link

Unga commented Nov 10, 2021

While I recommend against doing it

Why do you recommend not doing bundling?

@mcollina
Copy link
Member Author

Why do you recommend not doing bundling?

It's not needed and it complicates debugging and resolving production issues.

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
v7
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support bundlers.
feat: add bundlers test stack zekth/pino
3 participants
@mcollina @Unga @zekth