Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting errorKey means the error serializer doesn't work by default #1593

Closed
leighman opened this issue Nov 16, 2022 · 3 comments
Closed

Setting errorKey means the error serializer doesn't work by default #1593

leighman opened this issue Nov 16, 2022 · 3 comments
Labels
bug

Comments

@leighman
Copy link

By default the error serializer is hard-coded to the string err which means that it does not follow updates to errorKey correctly.
I would expect them to share the given key.
@mcollina
Copy link
Member

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

@mcollina mcollina added the bug label Nov 16, 2022
zahar517 added a commit to zahar517/pino that referenced this issue Dec 14, 2022
@zahar517
fix: update errorKey with default error serializer (pinojs#1593)
ab21166
@zahar517 zahar517 mentioned this issue Dec 14, 2022
Merged
@zahar517
Copy link
Contributor

@mcollina Hello!
Thanks for great library. I fixed it and added unit test.
Hope, everything is ok.
Have a nice day!

mcollina pushed a commit that referenced this issue Dec 14, 2022
@zahar517
fix: update errorKey with default error serializer (#1593) (#1604)
869f7bb 
Co-authored-by: zahar517 <zahar.d517@gmail.com>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mcollina @leighman @jsumners @zahar517