Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log level functionality broken when describing transmit #1861

Open
kyranjamie opened this issue Dec 7, 2023 · 1 comment
Open

Log level functionality broken when describing transmit #1861

kyranjamie opened this issue Dec 7, 2023 · 1 comment

Comments

@kyranjamie
Copy link

kyranjamie commented Dec 7, 2023

We're using Pino in the Leather web extension project, with the config:

const pinoLogger = pino({
  enabled: !IS_TEST_ENV,
  level: 'info',
  browser: {
    asObject: false,
    transmit: {
      level: 'info',
      send(_level, logEvent) {
        if (!chrome) return;
        logs$.next(logEvent);
      },
    },
  },
});

Not sure when this was introduced, but lately, pinoLogger.debug statements have been logging to console, despite the level being info. In debugging this, I've noticed that when removing the browser.transmit object, the logging behaviour works as expected.

@jsumners
Copy link
Member

jsumners commented Dec 7, 2023

Please provide a minimal reproducible example. Doing so will help us diagnose your issue. It should be the bare minimum code needed to trigger the issue, and easily runnable without any changes or extra code.

You may use a GitHub repository to host the code if it is too much to fit in a code block (or two).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants