Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs on speed difference of sync and async logging #1862

Open
bfelbo opened this issue Dec 12, 2023 · 2 comments
Open

Docs on speed difference of sync and async logging #1862

bfelbo opened this issue Dec 12, 2023 · 2 comments

Comments

@bfelbo
Copy link

bfelbo commented Dec 12, 2023

We're facing some pino logging issues and considering enabling sync: true to fix those. However, it's hard to make that tradeoff without understand the performance impact. The docs mention that "asynchronous logging enables the minimum overhead of Pino", but don't explain more than that.

Of course, this is application-specific and we can do a full benchmarking setup. That takes a lot of time though. It'd be very helpful to know for a standard Node.js webserver whether enabling sync: true usually has a 2x speed decrease or a 100x speed decrease. It'd be amazing to add this info in the docs.

I tried finding a forum/Slack/Discord of Pino users to ask this question, but I couldn't find any so I'm asking it here instead.

@kibertoad
Copy link
Contributor

Hey, Bjarke! Long time no see. I'll try to look it up!

@bfelbo
Copy link
Author

bfelbo commented Dec 12, 2023

Hey Igor, cool to see you here! Thanks for helping 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants