Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create-dockerfiles action doesn't start on release published #10936

Open
ga-ram opened this issue Apr 22, 2024 · 2 comments · Fixed by #10939
Open

create-dockerfiles action doesn't start on release published #10936

ga-ram opened this issue Apr 22, 2024 · 2 comments · Fixed by #10939

Comments

@ga-ram
Copy link
Contributor

ga-ram commented Apr 22, 2024

pinpoint/.github/workflows/create-dockerfiles.yml

Lines 3 to 5 in d1dd51d

on:
release:
types: [published]

It hasn't run with recent 2.5.4 release.
https://github.com/pinpoint-apm/pinpoint/actions/workflows/create-dockerfiles.yml
@ga-ram
Copy link
Contributor Author

ga-ram commented Apr 23, 2024

dockerfiles, modified pom, and create-dockerfiles.yml doesn't exist in 2.5.x branch.

@ga-ram ga-ram linked a pull request Apr 23, 2024 that will close this issue
Modify create-dockerfiles.yml #10939
Merged
@ga-ram
Copy link
Contributor Author

ga-ram commented Apr 23, 2024

released v2.5.4 docker images with previous pinpoint-docker action

create-dockerfiles needs to be manually started after next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify create-dockerfiles.yml pinpoint-apm/pinpoint
1 participant
@ga-ram