-
Notifications
You must be signed in to change notification settings - Fork 501
/
TrailingCommaOnCallSiteRule.kt
160 lines (145 loc) · 6.38 KB
/
TrailingCommaOnCallSiteRule.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
package com.pinterest.ktlint.ruleset.standard
import com.pinterest.ktlint.core.Rule
import com.pinterest.ktlint.core.api.EditorConfigProperties
import com.pinterest.ktlint.core.api.UsesEditorConfigProperties
import com.pinterest.ktlint.core.ast.ElementType
import com.pinterest.ktlint.core.ast.children
import com.pinterest.ktlint.ruleset.standard.internal.trailingcomma.reportAndCorrectTrailingCommaNodeBefore
import kotlin.properties.Delegates
import org.ec4j.core.model.PropertyType
import org.ec4j.core.model.PropertyType.PropertyValueParser
import org.jetbrains.kotlin.com.intellij.lang.ASTNode
import org.jetbrains.kotlin.com.intellij.psi.tree.TokenSet
/**
* Linting trailing comma for call site.
*
* @see [Kotlin Style Guide](https://kotlinlang.org/docs/coding-conventions.html#trailing-commas)
*/
public class TrailingCommaOnCallSiteRule :
Rule(
id = "trailing-comma-on-call-site",
visitorModifiers = setOf(
VisitorModifier.RunAfterRule(
ruleId = "standard:indent",
loadOnlyWhenOtherRuleIsLoaded = true,
runOnlyWhenOtherRuleIsEnabled = true
),
VisitorModifier.RunAsLateAsPossible
)
),
UsesEditorConfigProperties {
override val editorConfigProperties: List<UsesEditorConfigProperties.EditorConfigProperty<*>> = listOf(
allowTrailingCommaOnCallSiteProperty
)
private var allowTrailingCommaOnCallSite by Delegates.notNull<Boolean>()
private fun ASTNode.isTrailingCommaAllowed() =
elementType in TYPES_ON_CALL_SITE && allowTrailingCommaOnCallSite
override fun beforeFirstNode(editorConfigProperties: EditorConfigProperties) {
allowTrailingCommaOnCallSite = editorConfigProperties.getEditorConfigValue(allowTrailingCommaOnCallSiteProperty)
}
override fun beforeVisitChildNodes(
node: ASTNode,
autoCorrect: Boolean,
emit: (offset: Int, errorMessage: String, canBeAutoCorrected: Boolean) -> Unit
) {
// Keep processing of element types in sync with Intellij Kotlin formatting settings.
// https://github.com/JetBrains/intellij-kotlin/blob/master/formatter/src/org/jetbrains/kotlin/idea/formatter/trailingComma/util.kt
when (node.elementType) {
ElementType.COLLECTION_LITERAL_EXPRESSION -> visitCollectionLiteralExpression(node, autoCorrect, emit)
ElementType.INDICES -> visitIndices(node, autoCorrect, emit)
ElementType.TYPE_ARGUMENT_LIST -> visitTypeList(node, autoCorrect, emit)
ElementType.VALUE_ARGUMENT_LIST -> visitValueList(node, autoCorrect, emit)
else -> Unit
}
}
private fun visitCollectionLiteralExpression(
node: ASTNode,
autoCorrect: Boolean,
emit: (offset: Int, errorMessage: String, canBeAutoCorrected: Boolean) -> Unit
) {
val inspectNode = node
.children()
.last { it.elementType == ElementType.RBRACKET }
node.reportAndCorrectTrailingCommaNodeBefore(
inspectNode = inspectNode,
emit = emit,
isTrailingCommaAllowed = node.isTrailingCommaAllowed(),
autoCorrect = autoCorrect
)
}
private fun visitIndices(
node: ASTNode,
autoCorrect: Boolean,
emit: (offset: Int, errorMessage: String, canBeAutoCorrected: Boolean) -> Unit
) {
val inspectNode = node
.children()
.last { it.elementType == ElementType.RBRACKET }
node.reportAndCorrectTrailingCommaNodeBefore(
inspectNode = inspectNode,
emit = emit,
isTrailingCommaAllowed = node.isTrailingCommaAllowed(),
autoCorrect = autoCorrect
)
}
private fun visitValueList(
node: ASTNode,
autoCorrect: Boolean,
emit: (offset: Int, errorMessage: String, canBeAutoCorrected: Boolean) -> Unit
) {
if (node.treeParent.elementType != ElementType.FUNCTION_LITERAL) {
node
.children()
.lastOrNull { it.elementType == ElementType.RPAR }
?.let { inspectNode ->
node.reportAndCorrectTrailingCommaNodeBefore(
inspectNode = inspectNode,
emit = emit,
isTrailingCommaAllowed = node.isTrailingCommaAllowed(),
autoCorrect = autoCorrect
)
}
}
}
private fun visitTypeList(
node: ASTNode,
autoCorrect: Boolean,
emit: (offset: Int, errorMessage: String, canBeAutoCorrected: Boolean) -> Unit
) {
val inspectNode = node
.children()
.first { it.elementType == ElementType.GT }
node.reportAndCorrectTrailingCommaNodeBefore(
inspectNode = inspectNode,
emit = emit,
isTrailingCommaAllowed = node.isTrailingCommaAllowed(),
autoCorrect = autoCorrect
)
}
public companion object {
internal const val ALLOW_TRAILING_COMMA_ON_CALL_SITE_NAME = "ij_kotlin_allow_trailing_comma_on_call_site"
private const val ALLOW_TRAILING_COMMA_ON_CALL_SITE_DESCRIPTION =
"Defines whether a trailing comma (or no trailing comma)" +
"should be enforced on the calling side," +
"e.g. argument-list, when-entries, lambda-arguments, indices, etc."
private val BOOLEAN_VALUES_SET = setOf("true", "false")
// TODO: Rename property to trailingCommaOnCallSite. The word 'allow' is misleading as the comma is
// enforced when the property is enabled and prohibited when disabled.
public val allowTrailingCommaOnCallSiteProperty: UsesEditorConfigProperties.EditorConfigProperty<Boolean> =
UsesEditorConfigProperties.EditorConfigProperty(
type = PropertyType.LowerCasingPropertyType(
ALLOW_TRAILING_COMMA_ON_CALL_SITE_NAME,
ALLOW_TRAILING_COMMA_ON_CALL_SITE_DESCRIPTION,
PropertyValueParser.BOOLEAN_VALUE_PARSER,
BOOLEAN_VALUES_SET
),
defaultValue = false
)
private val TYPES_ON_CALL_SITE = TokenSet.create(
ElementType.COLLECTION_LITERAL_EXPRESSION,
ElementType.INDICES,
ElementType.TYPE_ARGUMENT_LIST,
ElementType.VALUE_ARGUMENT_LIST
)
}
}