Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traversion directory tree with relative patterns referring to directories outside work directory #2002

Closed
paul-dingemans opened this issue May 8, 2023 · 0 comments · Fixed by #2004
Closed

Traversion directory tree with relative patterns referring to directories outside work directory #2002

paul-dingemans opened this issue May 8, 2023 · 0 comments · Fixed by #2004
Milestone
0.49.1

Comments

@paul-dingemans
Copy link
Collaborator

If Ktlint CLI is started with a glob that refers to a directory that is not a child directory of the current working directory than no files in that directory will be found. The problem seems especially to occur when using Bash as it deals differently with glob expansion.

The easiest reproduction is running ktlint ../project-directory/src/**/*.kt in some subdirectory other than project-directory.

Originally posted by @jokinol in #1600 (comment)
@paul-dingemans paul-dingemans added this to the 0.49.1 milestone May 8, 2023
paul-dingemans added a commit that referenced this issue May 9, 2023
@paul-dingemans
Fix directory traversal for patterns referring to paths outside of cu…
d3610e1 
…rrent working directory or any of it child directories

Closes #2002
@paul-dingemans paul-dingemans mentioned this issue May 9, 2023
Merged
6 tasks
paul-dingemans added a commit that referenced this issue May 9, 2023
@paul-dingemans
Fix failing build on Windows when pattern contains a wildcard
c2c2f58 
Closes #2002
paul-dingemans added a commit that referenced this issue May 9, 2023
@paul-dingemans
Fix failing tests on Windows for relative path outside working directory
dc8d1a2 
Closes #2002
paul-dingemans added a commit that referenced this issue May 9, 2023
@paul-dingemans
Fix directory traversal for patterns outside workdirectory (#2004)
9256b8e 
Fix directory traversal for patterns referring to paths outside of current working directory or any of it child directories. Note that on Windows the (relative) patterns may not refer to a path outside of the current working directory.

Closes #2002
@paul-dingemans paul-dingemans mentioned this issue May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.49.1
Development

Successfully merging a pull request may close this issue.

Fix directory traversal for patterns outside workdirectory pinterest/ktlint
1 participant
@paul-dingemans