Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to Commits is broken in the Hotfixes landing page #1314

Open
t20 opened this issue Oct 24, 2023 · 1 comment
Open

Links to Commits is broken in the Hotfixes landing page #1314

t20 opened this issue Oct 24, 2023 · 1 comment

Comments

@t20
Copy link
Contributor

t20 commented Oct 24, 2023

Describe the bug
The hotfixes page shows a list of hotfixes.
E.g. https://deploy.example.com/env/myproject/prod/hotfixes/

In the page, the links to commits are broken

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Hotfixes'
  2. Click on any commits link
  3. If a user has specified a template, this is not considered. The link is broken. For example, it may point to a old code repo.

Expected behavior
Commit links are not broken

Screenshots

Desktop (please complete the following information):

  • OS: Mac OS
  • Browser [chrome]
  • Version [118.minor]

Additional context
Add any other context about the problem here.

@t20
Copy link
Contributor Author

t20 commented Oct 24, 2023

Here is a fix: #1310

liyaqin1 pushed a commit that referenced this issue Mar 13, 2024
#1310)

Hotfix landing page: Fix commit link by setting the build type in the url pattern.

The hotfixes landing page shows a list of hotfixes. For each hotfix, a
list of commits is also shown.
E.g. https://deploy.example.com/env/myproject/prod/hotfixes/

In the page, the links to commits are broken

To Reproduce
Steps to reproduce the behavior:

    Go to 'Hotfixes'
    Click on any commits link
    If a user has specified a template, this is not considered. The link is
       broken. For example, if you switched from a old version control system
       to github, it will still use the old version.

Some more details in #1314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant