Create new environment button on UI redirects to /None

[gvwirth]

Hello,

I'm setting up Teletraan in a containerized environment, and have deploy-board and deploy-service running in containers and, by all accounts, successfully communicating. When I go to click "Create environment" in the UI, I am redirected to "{ base_url }/None". Checking on the template that generates this button, I see that the button's URL is populated by this env var:

teletraan/deploy-board/deploy_board/settings.py

Line 232 in 1faf2b8

TELETRAAN_REDIRECT_CREATE_ENV_PAGE_URL = os.getenv("TELETRAAN_REDIRECT_CREATE_ENV_PAGE_URL", None)

Which is then referenced in the templates here (as an example):

teletraan/deploy-board/deploy_board/templates/environs/envs_base.html

Line 78 in 4315016

<a href='{{ redirect_create_env_page_url }}' target='_blank' class="deployToolTip btn btn-default btn-block">

Since I do not have this env var set, I am being redirected to /None. Here is a demo: https://ookla.d.pr/i5iDig

I tried setting this env var to a valid URL, but the Create Environment button then acts as a simple link to whatever I set the redirect URL to. At no point am I able to actually create an environment or presented with the correct dialog from the button click action.

Let me know if there is any more detail I can provide about my set up. Thanks!

EDIT:

Update on this -- I discovered that the issue is there is no data-target to the "newEnvModalId" within the template:

teletraan/deploy-board/deploy_board/templates/environs/envs_base.html

Line 78 in 0d17195

<a href='{{ redirect_create_env_page_url }}' target='_blank' class="deployToolTip btn btn-default btn-block">

This should be:

<a href="{{ redirect_create_env_page_url }}" target="_blank" class="deployToolTip btn btn-default btn-block" data-original-title="" title="" data-toggle="modal" data-target="#newEnvModalId">

I'd be happy to submit a PR to fix this if needed. Thanks!