Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open "create env" modal if redirect_create_env_page_url not supplied #689

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Open "create env" modal if redirect_create_env_page_url not supplied #689

wants to merge 3 commits into from
+5 −1

Conversation

moshe
Copy link
Contributor

@moshe moshe commented Sep 18, 2019 •
edited

I came into similar issue like @gvwirth at #686
Added new condition for checking redirect_create_env_page_url

closes #686

yongwen
yongwen previously approved these changes Sep 26, 2019
View reviewed changes
@tuck182
Copy link

tuck182 commented Nov 2, 2019

This link also appears in templates/environs/envs_landing.html. I believe the same change should be applied there.

@gvwirth
Copy link

gvwirth commented May 13, 2021

Hi -- any updates on getting these fixes merged? We're hoping to update our Teletraan installs and it'd be great if these fixes were merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongwen yongwen yongwen left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create new environment button on UI redirects to /None
4 participants
@moshe @tuck182 @gvwirth @yongwen