Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing migrations from the schema upgrade script. #700

Open
mignaulo opened this issue Jan 9, 2020 · 0 comments
Open

Missing migrations from the schema upgrade script. #700

mignaulo opened this issue Jan 9, 2020 · 0 comments

Comments

@mignaulo
Copy link

mignaulo commented Jan 9, 2020

Hello,
We have a fairly old Teletraan setup that we are planning to update to the latest version. This requires us to upgrade the MySQL schema. We have been doing testing the MySQL upgrade script and comparing them to https://github.com/pinterest/teletraan/blob/master/deploy-service/common/src/main/resources/sql/deploy.sql and noticed some discrepancies.

After some sleuthing, I tracked the changes down to this PR: #491
That PR updated the complete schema without creating a new schema_version. These are the changes missing: https://github.com/pinterest/teletraan/pull/491/files#diff-380d85d61edaf8019bd4a4cd16a48c36
I believe this migration would in theory live somewhere between schema_version 1 and 2.

We can definitely patch our setup without trouble, but I figured I would raise this issue regardless. I could create a PR to update the MySQL upgrade script to handle this and help others that might run into this. I could add the missing migrations to the end of tools/mysql/schema-update-1.sql or the beginning of tools/mysql/schema-update-2.sql. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant