Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite shell scripts in Go #163

Open
stv0g opened this issue Apr 12, 2023 · 7 comments · May be fixed by #212
Open

Rewrite shell scripts in Go #163

stv0g opened this issue Apr 12, 2023 · 7 comments · May be fixed by #212
Assignees
@kehiy
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@stv0g
Copy link
Member

stv0g commented Apr 12, 2023

I think we could try to rewrite our Bash-based linting scripts in Go.

WDYT?
@stv0g stv0g added enhancement New feature or request good first issue Good for newcomers labels Apr 12, 2023
@kehiy
Copy link
Member

kehiy commented Aug 30, 2023

@stv0g for getting this issue done. is there any thing to be considered?
or just rewrite them in go?

@Sean-Der
Copy link
Member

@kehiy nothing to consider! As long as they behave the same we are good to go :)

happy to help with testing/reviews

@kehiy
Copy link
Member

kehiy commented Sep 1, 2023

@Sean-Der okay, so I start work on this issue

@kehiy kehiy self-assigned this Sep 1, 2023
@stv0g
Copy link
Member Author

stv0g commented Sep 2, 2023

I agree with Sean here. Maybe we start with a single script per PR?

@kehiy
Copy link
Member

kehiy commented Sep 2, 2023 •
edited

@stv0g that's a good point
I will rewrite them one by one.

@kehiy kehiy mentioned this issue Sep 3, 2023
Merged
Sean-Der pushed a commit that referenced this issue Sep 10, 2023
@kehiy @Sean-Der
Port lint-filename to go
e0100b6 
Relates to #163
@Sean-Der
Copy link
Member

Merged! Thank you @kehiy

Keep up the great work. Would love to see those all merged (and this issue resolved)

@kehiy
Copy link
Member

kehiy commented Sep 10, 2023

@Sean-Der thank you so much.
yeap!
I will fix them one by one...

@kehiy kehiy mentioned this issue Sep 17, 2023
Closed
@DavidDiasN DavidDiasN linked a pull request May 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kehiy kehiy

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrote shell script as a go script DavidDiasN/ddFork-.goassets
3 participants
@stv0g @Sean-Der @kehiy